Just a corn on the internet.

Lemmy stores DMs in plain text. If that’s an issue for you, use the matrix contact @einkorn:tchncs.de for encrypted chats.

🇩🇪 DE/EN 🇬🇧

  • 3 Posts
  • 383 Comments
Joined 2 years ago
cake
Cake day: June 21st, 2024

help-circle


  • Simply put, the crime from drugs arises only from society criminalizing the supply. People want to have a good time and where there is a demand a supply follows. But the demand doesn’t go away because of the criminalization, just as you said. The substitute for illegal drugs (cocaine, heroin, …) are legal drugs (alcohol, nicotine, …). But as many users will tell you illegal drugs provide a whole different level of high. The substitute therefore is imperfect and we get to the situation we are at today.

    Thinking about guns: Which demand do they satisfy? Security? Every nation on earth operates a police force that is trained in and tasked with upholing law and order (to which extend they do is a different debate). Therefore the average citizen does not need a weapon for self-defense. Skillfull competition? There are many other fields people can compete in. If it has to be loud and make a bang there is i.e. rocket assisted model aviation just to name one. Guns can therefore be reasonably substituted by other means.










  • If a feature request requires changes of such a magnitude it is important to break them down into smaller chunks that can be reviewed either independently or sequentially.

    I have never rejected a PR before because no matter how bad a PR is, it always is technically necessary for the feature.

    Define bad? If the PR contains lots of unnecessary changes such as formatting or renaming simply tell the person to roll them back and come again unless they have very good reason to do so.

    If the code quality is bad, well, that’s why you are doing the review. If all that matters was “Does it do what it is supposed to do most of the time?” some simple unit tests would be enough. Reviewing code means making sure it does what is supposed to do and does so in an acceptable manner. Criteria can be amongst others speed, security, ease of use or maintainability.

    • Insecure handling of inputs? Add sanitisation and resubmit.
    • Overusage of resource intensive features such as database queries? Group and optimize queries and resubmit.
    • The codes formatting is not according to the internal style guide? Configure your damn linter and resubmit.
    • …

    If you don’t want to close PRs outright you can request new commits that fix the issues you identified, reevaluate the PR and decide again.